Let workflows add reactions to messages#2494
Open
BradGroux wants to merge 1 commit into
Open
Conversation
Co-authored-by: Brad Groux <bradgroux@hotmail.com> Signed-off-by: Brad Groux <bradgroux@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2395.
What users saw
A workflow with
add_reactionalways failed at that step. The executor posted to/api/messages/{id}/reactions, but Buzz has no such route, so the 404 aborted the run and prevented every later step from running.Why it happened
send_messagealready uses the relay's in-process workflow action sink.add_reactioninstead used a loopback HTTP request that depended on an endpoint and authentication path that do not exist.What changes
add_reactionthrough the same in-process action sink as other workflow side effects.Regression proof
cargo test -p buzz-workflow— 149 passed.cargo test -p buzz-relay --lib workflow_sink— 17 passed, 2 infrastructure tests ignored by default.send_messagestep still runs.just test— all eight repository test groups passed.just ci— passed Rust formatting and clippy, TypeScript/Biome and Dart analysis, Rust/JavaScript/Flutter test suites, and Desktop/web builds.The additional affected-package run,
cargo test -p buzz-workflow -p buzz-relay -p buzz-test-client --no-fail-fast, passed the workflow and test-client packages and 734 relay tests. The unrelatedapi::mesh_demo::tests::demo_join_forwarded_arm_round_trips_echotest returned the same HTTP 504 both on this branch and on a clean checkout oforigin/mainatacfbb1bb; this change does not touch the mesh path.Scope
add_reactionbecause they do not have a triggering message ID.